]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix regression in setups without a client certificate
authorSteffan Karger <steffan@karger.me>
Sun, 3 Jan 2016 09:47:56 +0000 (10:47 +0100)
committerGert Doering <gert@greenie.muc.de>
Sun, 3 Jan 2016 09:50:26 +0000 (10:50 +0100)
commit868d9d01802da9bbbb3a758981f3c7310a905813
treedd04894f62f2217b6e999045cfb3ae321c15ccf5
parentcdc65ea0f1f94974f55352d794627561c78c4151
Fix regression in setups without a client certificate

This fixes a null-pointer dereference in tls_ctx_cert_time(), which will
occur on clients that do not use a client certificate (ie that only have
auth-user-pass in the config, but no key and cert).  This bug was
introduced by commit 091edd8e on the master branch, and commit dfd940bb
on the release/2.3 branch.

This bug was found by chipitsine and reported in trac ticket #644.

While touching this function, I also made this function conform to the
openvpn coding style.

v2 - fix memory leak in builds using pre-1.0.2 openssl

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1451814476-32574-1-git-send-email-steffan@karger.me>
URL: http://article.gmane.org/gmane.network.openvpn.devel/10921
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/ssl_openssl.c
src/openvpn/ssl_polarssl.c