]> git.ipfire.org Git - thirdparty/linux.git/commit
tty: serial: samsung: Fix A7-A11 serial earlycon SError
authorNick Chan <towinchenmi@gmail.com>
Wed, 11 Sep 2024 05:02:12 +0000 (13:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Sep 2024 13:47:13 +0000 (15:47 +0200)
commit86d4ac2c0c31649f73bcbb424f9e1fb68c07cd60
treee5c2bfd0fd303f2693bffef8b236abbbde3bab4e
parent4c59c59ef3ab9275f2a8f84dcffbd16c285ce8ea
tty: serial: samsung: Fix A7-A11 serial earlycon SError

Apple's earlier SoCs, like A7-A11, requires 32-bit writes for the serial
port. Otherwise, a SError happens when writing to UTXH (+0x20). This only
manifested in earlycon as reg-io-width in the device tree is consulted
for normal serial writes.

Change the iotype of the port to UPIO_MEM32, to allow the serial port to
function on A7-A11 SoCs. This change does not appear to affect Apple M1 and
above.

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Tested-by: Janne Grunau <j@jannau.net>
Signed-off-by: Nick Chan <towinchenmi@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20240911050741.14477-3-towinchenmi@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/samsung_tty.c