]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drivers: media: dvb-frontends/rtl2830: fix an out-of-bounds write error
authorJunlin Li <make24@iscas.ac.cn>
Tue, 2 Jul 2024 17:50:23 +0000 (01:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:00 +0000 (15:11 +0200)
commit86d920d2600c3a48efc2775c1666c1017eec6956
tree53400709c5b3ecd8109e2c7a2020e76f650f771e
parenta879b6cdd48134a3d58949ea4f075c75fa2d7d71
drivers: media: dvb-frontends/rtl2830: fix an out-of-bounds write error

[ Upstream commit 46d7ebfe6a75a454a5fa28604f0ef1491f9d8d14 ]

Ensure index in rtl2830_pid_filter does not exceed 31 to prevent
out-of-bounds access.

dev->filters is a 32-bit value, so set_bit and clear_bit functions should
only operate on indices from 0 to 31. If index is 32, it will attempt to
access a non-existent 33rd bit, leading to out-of-bounds access.
Change the boundary check from index > 32 to index >= 32 to resolve this
issue.

Fixes: df70ddad81b4 ("[media] rtl2830: implement PID filter")
Signed-off-by: Junlin Li <make24@iscas.ac.cn>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/dvb-frontends/rtl2830.c