]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Remove Before=libvirt-guests.service from other services
authorMartin Kletzander <mkletzan@redhat.com>
Wed, 26 Oct 2022 12:43:39 +0000 (14:43 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Thu, 27 Oct 2022 15:39:19 +0000 (17:39 +0200)
commit86e27b3506cf2aacc86c4286c21623fbaf57e468
treeaea71b00f571aa3aeef5a82cf294705049a4f086
parent92e78dab34e841ca9543a0e28069a53a902787b6
Remove Before=libvirt-guests.service from other services

libvirt-guests has After= dependency for all the sockets and that is enough.
With the extra Before= in the service file systemd postpones the start of the
socket activated service (when libvirt-guests is trying to connect to the
socket) until after libvirt-guests is stopped effectively making `systemctl stop
libvirt-guests` deadlock.  The reason for that is that all stop jobs are
scheduled before any start job.  Removing the redundant Before= specification
fixes this behaviour.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/ch/virtchd.service.in
src/lxc/virtlxcd.service.in
src/qemu/virtqemud.service.in
src/remote/libvirtd.service.in