]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mac80211: bail out if cipher schemes are invalid
authorJohannes Berg <johannes.berg@intel.com>
Thu, 8 Apr 2021 12:31:50 +0000 (14:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 08:50:06 +0000 (10:50 +0200)
commit86f3e44e95b077eebf1f22a84227dbb5b2bfd062
treeb1384ed24c0c343b8e77f1f695d74c370a7e7ca4
parent84993149bd645589e0f96cf237d45f5e229a00ea
mac80211: bail out if cipher schemes are invalid

[ Upstream commit db878e27a98106a70315d264cc92230d84009e72 ]

If any of the cipher schemes specified by the driver are invalid, bail
out and fail the registration rather than just warning.  Otherwise, we
might later crash when we try to use the invalid cipher scheme, e.g.
if the hdr_len is (significantly) less than the pn_offs + pn_len, we'd
have an out-of-bounds access in RX validation.

Fixes: 2475b1cc0d52 ("mac80211: add generic cipher scheme support")
Link: https://lore.kernel.org/r/20210408143149.38a3a13a1b19.I6b7f5790fa0958ed8049cf02ac2a535c61e9bc96@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/mac80211/main.c