]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: core: pair EH runtime PM get and put
authorHongjie Fang <hongjiefang@asrmicro.com>
Wed, 29 Jul 2026 11:16:14 +0000 (19:16 +0800)
committerMartin K. Petersen (Oracle) <mkp@kernel.org>
Fri, 7 Aug 2026 15:00:49 +0000 (11:00 -0400)
commit872f486259ae0bc6b73ca4735a15d013241f73e9
tree9f45b7ea9f0682c5303296a081927f811837d6d2
parent0279fd451a9971c0d5b959fc59f3e11b55e1694e
scsi: core: pair EH runtime PM get and put

shost->eh_noresume is currently consulted twice in one error handling
iteration: once before scsi_autopm_get_host() and once again before
scsi_autopm_put_host().

That is racy when a PM-triggered error path flips shost->eh_noresume
while the SCSI EH thread is still running.

The problem flow looks like this:
PM path
  ufshcd_set_dev_pwr_mode()
    shost->eh_noresume = 1
    ufshcd_execute_start_stop  <-- trigger EH
    ...
    shost->eh_noresume = 0

EH path
  scsi_error_handler()
    if (!shost->eh_noresume)
      scsi_autopm_get_host()  <-- skipped
    ...
    if (!shost->eh_noresume)
       scsi_autopm_put_host()  <-- executed later

In that case one EH iteration can skip autoresume on entry and still
drop a runtime PM reference on exit. That leaves an unmatched runtime PM
put and can trigger a runtime PM usage count underflow.

Fix this by making eh_noresume a regular bool so it can be accessed with
READ_ONCE() and WRITE_ONCE(). Snapshot it once per EH iteration and use
that snapshot for both runtime PM get and put decisions.

Fixes: ae0751ffc77e ("[SCSI] add flag to skip the runtime PM calls on the host")
Signed-off-by: Hongjie Fang <hongjiefang@asrmicro.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Link: https://patch.msgid.link/20260729111614.2407559-1-hongjiefang@asrmicro.com
Signed-off-by: Martin K. Petersen (Oracle) <mkp@kernel.org>
drivers/scsi/scsi_error.c
drivers/ufs/core/ufshcd.c
include/scsi/scsi_host.h