]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: rtsx_pci_sdmmc: fix incorrect last byte in R2 response
authorRoger Tseng <rogerable@realtek.com>
Fri, 15 Aug 2014 06:06:00 +0000 (14:06 +0800)
committerJiri Slaby <jslaby@suse.cz>
Thu, 13 Nov 2014 18:02:08 +0000 (19:02 +0100)
commit87394e735e609660eceb70e505f6d8b7c7a1eaba
tree52beb659f7a8c2cb05c86f437cd19a4b822439e8
parent9e5e18105b8ac7f8e5167f396c0eeb2aaef6e003
mmc: rtsx_pci_sdmmc: fix incorrect last byte in R2 response

commit d1419d50c1bf711e9fd27b516a739c86b23f7cf9 upstream.

Current code erroneously fill the last byte of R2 response with an undefined
value. In addition, the controller actually 'offloads' the last byte
(CRC7, end bit) while receiving R2 response and thus it's impossible to get the
actual value. This could cause mmc stack to obtain inconsistent CID from the
same card after resume and misidentify it as a different card.

Fix by assigning dummy CRC and end bit: {7'b0, 1} = 0x1 to the last byte of R2.

Fixes: ff984e57d36e ("mmc: Add realtek pcie sdmmc host driver")
Signed-off-by: Roger Tseng <rogerable@realtek.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/mmc/host/rtsx_pci_sdmmc.c