]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
PCI: aardvark: Do not clear status bits of masked interrupts
authorPali Rohár <pali@kernel.org>
Tue, 5 Oct 2021 18:09:45 +0000 (20:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:36:02 +0000 (11:36 +0100)
commit8753b5a686c1ba6a7b18e2e2cb41ccddf2aecee7
tree60051f2dfb6de9ca1d30e4e69a4651e14a610f62
parentf53f35a99e49445ea58ed30663d99dba4e0efa3d
PCI: aardvark: Do not clear status bits of masked interrupts

commit a7ca6d7fa3c02c032db5440ff392d96c04684c21 upstream.

The PCIE_ISR1_REG says which interrupts are currently set / active,
including those which are masked.

The driver currently reads this register and looks if some unmasked
interrupts are active, and if not, it clears status bits of _all_
interrupts, including the masked ones.

This is incorrect, since, for example, some drivers may poll these bits.

Remove this clearing, and also remove this early return statement
completely, since it does not change functionality in any way.

Link: https://lore.kernel.org/r/20211005180952.6812-7-kabel@kernel.org
Fixes: 8c39d710363c ("PCI: aardvark: Add Aardvark PCI host controller driver")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Marek Behún <kabel@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/controller/pci-aardvark.c