]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
usb: cdns3: gadget: Use-after-free during failed initialization and exit of cdnsp...
authorChen Yufeng <chenyufeng@iie.ac.cn>
Fri, 5 Sep 2025 09:48:42 +0000 (17:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Sep 2025 13:24:05 +0000 (15:24 +0200)
commit87c5ff5615dc0a37167e8faf3adeeddc6f1344a3
treef0de1d59a7380761f11bdc056a5ba7e439b22fd7
parente9c206324eeb213957a567a9d066bdeb355c7491
usb: cdns3: gadget: Use-after-free during failed initialization and exit of cdnsp gadget

In the __cdnsp_gadget_init() and cdnsp_gadget_exit() functions, the gadget
structure (pdev->gadget) was freed before its endpoints.
The endpoints are linked via the ep_list in the gadget structure.
Freeing the gadget first leaves dangling pointers in the endpoint list.
When the endpoints are subsequently freed, this results in a use-after-free.

Fix:
By separating the usb_del_gadget_udc() operation into distinct "del" and
"put" steps, cdnsp_gadget_free_endpoints() can be executed prior to the
final release of the gadget structure with usb_put_gadget().

A patch similar to bb9c74a5bd14("usb: dwc3: gadget: Free gadget structure
 only after freeing endpoints").

Signed-off-by: Chen Yufeng <chenyufeng@iie.ac.cn>
Link: https://lore.kernel.org/r/20250905094842.1232-1-chenyufeng@iie.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdnsp-gadget.c