]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: Intel: sof_sdw: Prevent jump to NULL add_sidecar callback
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Fri, 19 Sep 2025 14:02:35 +0000 (15:02 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 19 Sep 2025 14:11:47 +0000 (15:11 +0100)
commit87cab86925b7fa4c1c977bc191ac549a3b23f0ea
tree6bfaab70fca1c3a62f742d6cc62d58bf78a04f0d
parent62a7b3bbb6b873fdcc85a37efbd0102d66c8a73e
ASoC: Intel: sof_sdw: Prevent jump to NULL add_sidecar callback

In create_sdw_dailink() check that sof_end->codec_info->add_sidecar
is not NULL before calling it.

The original code assumed that if include_sidecar is true, the codec
on that link has an add_sidecar callback. But there could be other
codecs on the same link that do not have an add_sidecar callback.

Fixes: da5244180281 ("ASoC: Intel: sof_sdw: Add callbacks to register sidecar devices")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20250919140235.1071941-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/sof_sdw.c