]> git.ipfire.org Git - thirdparty/libvirt.git/commit
virrandom: make virRandomInitialize an automatic one-shot
authorEric Blake <eblake@redhat.com>
Fri, 3 Aug 2012 23:15:00 +0000 (17:15 -0600)
committerEric Blake <eblake@redhat.com>
Mon, 6 Aug 2012 14:15:13 +0000 (08:15 -0600)
commit87de27b7f9296c90b6f4e35eeb5448db491dcba2
tree9f9ca1dc0ba8a8f5d9bbab97547642ac55a5d526
parent1d5bc382208023f95d2cd78b8b9037b1cfa9415a
virrandom: make virRandomInitialize an automatic one-shot

All callers used the same initialization seed (well, the new
viratomictest forgot to look at getpid()); so we might as well
make this value automatic.  And while it may feel like we are
giving up functionality, I documented how to get it back in the
unlikely case that you actually need to debug with a fixed
pseudo-random sequence.  I left that crippled by default, so
that a stray environment variable doesn't cause a lack of
randomness to become a security issue.

* src/util/virrandom.c (virRandomInitialize): Rename...
(virRandomOnceInit): ...and make static, with one-shot call.
Document how to do fixed-seed debugging.
* src/util/virrandom.h (virRandomInitialize): Drop prototype.
* src/libvirt_private.syms (virrandom.h): Don't export it.
* src/libvirt.c (virInitialize): Adjust caller.
* src/lxc/lxc_controller.c (main): Likewise.
* src/security/virt-aa-helper.c (main): Likewise.
* src/util/iohelper.c (main): Likewise.
* tests/seclabeltest.c (main): Likewise.
* tests/testutils.c (virtTestMain): Likewise.
* tests/viratomictest.c (mymain): Likewise.
src/libvirt.c
src/libvirt_private.syms
src/lxc/lxc_controller.c
src/security/virt-aa-helper.c
src/util/iohelper.c
src/util/virrandom.c
src/util/virrandom.h
tests/seclabeltest.c
tests/testutils.c
tests/viratomictest.c