]> git.ipfire.org Git - thirdparty/linux.git/commit
mei: vsc: Don't re-init VSC from mei_vsc_hw_reset() on stop
authorHans de Goede <hansg@kernel.org>
Mon, 23 Jun 2025 08:50:44 +0000 (10:50 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jun 2025 15:39:00 +0000 (16:39 +0100)
commit880af854d6343b796f05b9a8b52b68a88535625b
tree22afd11eb3bd97d47c45e26cdcbe22209757e577
parenta49159aa80207d49569b7453b4838f2f9501a17c
mei: vsc: Don't re-init VSC from mei_vsc_hw_reset() on stop

mei_vsc_hw_reset() gets called from mei_start() and mei_stop() in
the latter case we do not need to re-init the VSC by calling vsc_tp_init().

mei_stop() only happens on shutdown and driver unbind. On shutdown we
don't need to load + boot the firmware and if the driver later is
bound to the device again then mei_start() will do another reset.

The intr_enable flag is true when called from mei_start() and false on
mei_stop(). Skip vsc_tp_init() when intr_enable is false.

This avoids unnecessarily uploading the firmware, which takes 11 seconds.
This change reduces the poweroff/reboot time by 11 seconds.

Fixes: 386a766c4169 ("mei: Add MEI hardware support for IVSC device")
Signed-off-by: Hans de Goede <hansg@kernel.org>
Reviewed-by: Alexander Usyskin <alexander.usyskin@intel.com>
Link: https://lore.kernel.org/r/20250623085052.12347-3-hansg@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/platform-vsc.c