]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-106581: Fix two bugs in the code generator's copy optimization (#108380)
authorGuido van Rossum <guido@python.org>
Thu, 24 Aug 2023 19:10:51 +0000 (12:10 -0700)
committerGitHub <noreply@github.com>
Thu, 24 Aug 2023 19:10:51 +0000 (19:10 +0000)
commit88941d665fc6b345f38b9147a7321e40019964d5
tree90c5be62832700767b7183d9b8891f1b8372d20c
parentc494fb333b57bdf43fc90189fc29a00c293b2987
gh-106581: Fix two bugs in the code generator's copy optimization (#108380)

I was comparing the last preceding poke with the *last* peek,
rather than the *first* peek.

Unfortunately this bug obscured another bug:
When the last preceding poke is UNUSED, the first peek disappears,
leaving the variable unassigned. This is how I fixed it:

- Rename CopyEffect to CopyItem.
- Change CopyItem to contain StackItems instead of StackEffects.
- Update those StackItems when adjusting the manager higher or lower.
- Assert that those StackItems' offsets are equivalent.
- Other clever things.

---------

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Python/generated_cases.c.h
Tools/cases_generator/stacking.py