]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
clk: xilinx: vcu: unregister pll_post only if registered correctly
authorRohit Visavalia <rohit.visavalia@amd.com>
Mon, 10 Feb 2025 11:36:13 +0000 (03:36 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Aug 2025 10:05:01 +0000 (12:05 +0200)
commit88bd875b7f9c3652c27d6e4bb7a23701b764f762
tree639dfd7db9bd17eefac3ae531d71df55ec2b49ed
parent34a40f091f72ac9d8b72bb0cd1a435b52405239d
clk: xilinx: vcu: unregister pll_post only if registered correctly

[ Upstream commit 3b0abc443ac22f7d4f61ddbbbbc5dbb06c87139d ]

If registration of pll_post is failed, it will be set to NULL or ERR,
unregistering same will fail with following call trace:

Unable to handle kernel NULL pointer dereference at virtual address 008
pc : clk_hw_unregister+0xc/0x20
lr : clk_hw_unregister_fixed_factor+0x18/0x30
sp : ffff800011923850
...
Call trace:
 clk_hw_unregister+0xc/0x20
 clk_hw_unregister_fixed_factor+0x18/0x30
 xvcu_unregister_clock_provider+0xcc/0xf4 [xlnx_vcu]
 xvcu_probe+0x2bc/0x53c [xlnx_vcu]

Fixes: 4472e1849db7 ("soc: xilinx: vcu: make pll post divider explicit")
Signed-off-by: Rohit Visavalia <rohit.visavalia@amd.com>
Link: https://lore.kernel.org/r/20250210113614.4149050-2-rohit.visavalia@amd.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/xilinx/xlnx_vcu.c