]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ipmi:ssif: Improve detecting during probing
authorCorey Minyard <corey@minyard.net>
Wed, 21 Aug 2024 00:46:47 +0000 (19:46 -0500)
committerCorey Minyard <corey@minyard.net>
Wed, 21 Aug 2024 00:51:34 +0000 (19:51 -0500)
commit88f65f903d25aed8801d795470042754cb18ec67
treeb657bfa015de7e74debadc5d0dcaf1935d82d116
parent0e38f7ecb55c86c0bdb45ed817bac5a49cdeac04
ipmi:ssif: Improve detecting during probing

If an IPMI SSIF device is probed and there is something there, but
probably not an actual BMC, the code would just issue a lot of errors
before it failed.  We kind of need these errors to help with certain
issues, and some of the failure reports are non-fatal.

However, a get device id command should alway work.  If that fails,
nothing else is going to work and it's a pretty good indication that
there's no valid BMC there.  So issue and check that command and bail
if it fails.

Reported-by: Ivan T. Ivanov <iivanov@suse.de>
Signed-off-by: Corey Minyard <corey@minyard.net>
drivers/char/ipmi/ipmi_ssif.c