]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
fs: efs: remove unneeded debug prints
authorMaxwell Doose <m32285159@gmail.com>
Fri, 5 Jun 2026 03:52:51 +0000 (22:52 -0500)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 11 Jun 2026 18:42:21 +0000 (11:42 -0700)
commit89009392c80da5da00876c8334ff20028e6e3eb6
tree430b04af6412da4ecd59cffd217438f995adcd03
parent66cbd504306bf354231b1fbe43585b9aaa242d28
fs: efs: remove unneeded debug prints

The current code uses debug prints conditionally compiled with #ifdef
DEBUG.  However, that code, when compiled, causes compiler errors due to
incompatible formatters and undefined variables, notably:

fs/efs/file.c: In function `efs_get_block':
fs/efs/file.c:26:35: error: `block' undeclared (first use in this
function); did you mean `iblock'?
  26 |                         __func__, block, inode->i_blocks, inode->i_size);
     |                                   ^~~~~

and:

fs/efs/file.c: In function `efs_bmap':
./include/linux/kern_levels.h:5:25: error: format `%ld' expects
argument of type `long int', but argument 4 has type `blkcnt_t' {aka
`long long unsigned int'} [-Werror=format=]
   5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
     |                         ^~~~~~

which also extends to the other formatters.  As this part of the code has
been dead for just about 14 years now, it has not been modernized to stay
compatible with the most recent gcc compilers.  Fix these issues by
removing the debug prints.

Link: https://lore.kernel.org/20260605035251.89305-2-m32285159@gmail.com
Fixes: f403d1dbac6d ("fs/efs: add pr_fmt / use __func__")
Signed-off-by: Maxwell Doose <m32285159@gmail.com>
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Fabian Frederick <fabf@skynet.be>
Cc: Christian Brauner <brauner@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/efs/file.c