]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()
authorLi Jinlin <lijinlin3@huawei.com>
Tue, 7 Sep 2021 12:12:42 +0000 (20:12 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 26 Sep 2021 11:39:49 +0000 (13:39 +0200)
commit8936b8ef85ecb5685f9b9656b4904b95c7362dac
treec8bda27f8d169a1bac25848a4db088aefee632d9
parentf7ca7b67a07e550c30f43a732c17a324614de377
blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()

[ Upstream commit 884f0e84f1e3195b801319c8ec3d5774e9bf2710 ]

The pending timer has been set up in blk_throtl_init(). However, the
timer is not deleted in blk_throtl_exit(). This means that the timer
handler may still be running after freeing the timer, which would
result in a use-after-free.

Fix by calling del_timer_sync() to delete the timer in blk_throtl_exit().

Signed-off-by: Li Jinlin <lijinlin3@huawei.com>
Link: https://lore.kernel.org/r/20210907121242.2885564-1-lijinlin3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/blk-throttle.c