]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Improve stability of test with vacuum_truncate in reloptions.sql
authorMichael Paquier <michael@paquier.xyz>
Fri, 2 Apr 2021 00:44:50 +0000 (09:44 +0900)
committerMichael Paquier <michael@paquier.xyz>
Fri, 2 Apr 2021 00:44:50 +0000 (09:44 +0900)
commit89937d001294b39469790e5a583e438af2ca1235
tree1c8b431f081ff73fb2076e67e1aedf1e6fc36198
parent35421a470de16565e5dca87dc4e2b76fa19c7d08
Improve stability of test with vacuum_truncate in reloptions.sql

This test has been using a simple VACUUM with pg_relation_size() to
check if a relation gets physically truncated or not, but forgot the
fact that some concurrent activity, like checkpoint buffer writes, could
cause some pages to be skipped.  The second test enabling
vacuum_truncate could fail, seeing a non-empty relation.  The first test
would not have failed, but could finish by testing a behavior different
than the one aimed for.  Both tests gain a FREEZE option, to make the
vacuums more aggressive and prevent page skips.

This is similar to the issues fixed in c2dc1a7.

Author: Arseny Sher
Reviewed-by: Masahiko Sawada
Discussion: https://postgr.es/m/87tuotr2hh.fsf@ars-thinkpad
backpatch-through: 12
src/test/regress/expected/reloptions.out
src/test/regress/sql/reloptions.sql