]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
llc: Fix missing msg_namelen update in llc_ui_recvmsg()
authorMathias Krause <minipli@googlemail.com>
Sun, 7 Apr 2013 01:51:56 +0000 (01:51 +0000)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Mon, 10 Feb 2014 21:10:48 +0000 (16:10 -0500)
commit89b258e930ecf55c2c9a7c0fb0c428dc45f87980
treeef19b958dfd27a9d1c560a7c09c4da1fc15de136
parentd798b105cee33543b235410d2510219fa887b4d2
llc: Fix missing msg_namelen update in llc_ui_recvmsg()

commit c77a4b9cffb6215a15196ec499490d116dfad181 upstream.

For stream sockets the code misses to update the msg_namelen member
to 0 and therefore makes net/socket.c leak the local, uninitialized
sockaddr_storage variable to userland -- 128 bytes of kernel stack
memory. The msg_namelen update is also missing for datagram sockets
in case the socket is shutting down during receive.

Fix both issues by setting msg_namelen to 0 early. It will be
updated later if we're going to fill the msg_name member.

Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/llc/af_llc.c