]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
[2.7] bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033...
authorSerhiy Storchaka <storchaka@gmail.com>
Wed, 19 Dec 2018 15:11:02 +0000 (17:11 +0200)
committerGitHub <noreply@github.com>
Wed, 19 Dec 2018 15:11:02 +0000 (17:11 +0200)
commit89b5ea297d67f5efeb8fca0b63fa3d9f7030b2f0
tree7f9896f404b8a3957654367de2899fd363c2250b
parent838645dc4191c4109e2b300cf9ed9d481b55509f
[2.7] bpo-35441: Remove dead and buggy code related to PyList_SetItem(). (GH-11033) (GH-11234)

In _localemodule.c and selectmodule.c, remove dead code that would
cause double decrefs if run.

In addition, replace PyList_SetItem() with PyList_SET_ITEM() in cases
where a new list is populated and there is no possibility of an error.

In addition, check if the list changed size in the loop in array_array_fromlist().
(cherry picked from commit 99d56b53560b3867844472ae381fb3f858760621)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Modules/_localemodule.c
Modules/arraymodule.c
Modules/readline.c
Modules/selectmodule.c
Python/ceval.c
Python/sysmodule.c