]> git.ipfire.org Git - thirdparty/squid.git/commit
Remove bogus "found KEY_PRIVATE" WARNINGs (#862)
authorAlex Rousskov <rousskov@measurement-factory.com>
Thu, 15 Jul 2021 05:58:19 +0000 (05:58 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Thu, 15 Jul 2021 18:07:50 +0000 (18:07 +0000)
commit8a07d123ef7e986b601731fdaf4c93cc32471c73
treeab37a0d71a97031f4fa043b97c7c6f6c0af352e1
parent6e70401d97328eb4c267d1013428109224d093e6
Remove bogus "found KEY_PRIVATE" WARNINGs (#862)

... triggered by private bumped StoreEntry unlock()ed in ~ServerBump().

The WARNINGs were added long time ago (commit fc8b9fc) because, AFAICT,
earlier Store code expected StoreEntry owners to release() uncachable
entries, including KEY_PRIVATE ones, right before unlocking them.
However, there is no compile-time enforcement of that expectation, and
unlocking code does not always know whether the entry is cachable (as
ServerBump constructor/destructor RAII code illustrates).

This change stops tying release and unlocking decisions/actions together
but makes sure that idle KEY_PRIVATE entries are still released (because
we do not want to index unneeded/unusable Store entries).
src/clients/FtpRelay.cc
src/store.cc
src/store/Controller.cc