]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix PASS_BY_VALUE issue in options_postprocess_mutate_le()
authorGianmarco De Gregori <gianmarco@mandelbit.com>
Fri, 24 Jan 2025 13:00:00 +0000 (14:00 +0100)
committerGert Doering <gert@greenie.muc.de>
Fri, 24 Jan 2025 13:58:47 +0000 (14:58 +0100)
commit8a0f297e068b6701acceafc5af92eddd18a4151b
treeaf20d027b734b217aa94c8a00b27834c846ad5ef
parentcbb0440ee884ba3c052066d915d6fd7ce86befd2
Fix PASS_BY_VALUE issue in options_postprocess_mutate_le()

Fix issue reported by Coverity:
CID 1641424: Performance inefficiencies (PASS_BY_VALUE)
    Passing parameter ce of type "struct connection_entry"
    (size 208 bytes) by value, which exceeds the low
    threshold of 128 bytes.

Commit 8466c2ca unintentionally introduced a performance
penalty due to passing struct connection_entry 'ce'
by value to options_postprocess_mutate_le().
fix this by passing 'ce' by address.

Change-Id: I0542df021ae0ba9c982335fed7bbd10ed326dd0f
Signed-off-by: Gianmarco De Gregori <gianmarco@mandelbit.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20250124130000.20067-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30566.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/options.c