]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netpoll: Use rcu_access_pointer() in __netpoll_setup
authorBreno Leitao <leitao@debian.org>
Mon, 18 Nov 2024 11:15:17 +0000 (03:15 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:51:40 +0000 (19:51 +0100)
commit8a4534483e02c885032cbb16f2c4b513ee1b84d4
tree21a24fe1a45263a932bcdc784973a2aaea831a1c
parenta7b8f71c7a29e5f5c9eaf76d92afce6600b217cc
netpoll: Use rcu_access_pointer() in __netpoll_setup

[ Upstream commit c69c5e10adb903ae2438d4f9c16eccf43d1fcbc1 ]

The ndev->npinfo pointer in __netpoll_setup() is RCU-protected but is being
accessed directly for a NULL check. While no RCU read lock is held in this
context, we should still use proper RCU primitives for consistency and
correctness.

Replace the direct NULL check with rcu_access_pointer(), which is the
appropriate primitive when only checking for NULL without dereferencing
the pointer. This function provides the necessary ordering guarantees
without requiring RCU read-side protection.

Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20241118-netpoll_rcu-v1-1-a1888dcb4a02@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/netpoll.c