]> git.ipfire.org Git - thirdparty/krb5.git/commit
Fix EOF check in kadm5.acl line processing
authorRobbie Harwood <rharwood@redhat.com>
Wed, 13 Jan 2016 23:17:09 +0000 (18:17 -0500)
committerTom Yu <tlyu@mit.edu>
Fri, 15 Jan 2016 22:06:12 +0000 (17:06 -0500)
commit8a697b6ef9d4e528a33c66c781403698551982fc
tree2a15b0031d2802ffa9c9ada128033d391455985e
parentfd0eb62f85e1f57d07aec72bec73a90f5032b60b
Fix EOF check in kadm5.acl line processing

On platforms where the char type is unsigned, the check for EOF (which
is negative) will always fail, leaving a 255 byte at the end of the
line.  This can cause a syntax error, in turn causing the contents of
kadm5.acl to be ignored.  Fix this bug by removing the cast on EOF.

[ghudson@mit.edu: more precisely describe consequences of bug in
commit message]

(cherry picked from commit 8fd85a77789496b8d7f8092f6e8a2824bc09a6cf)

ticket: 8346
version_fixed: 1.13.4
tags: -pullup
status: resolved
src/lib/kadm5/srv/server_acl.c