]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
platform/wmi: use generic driver_override infrastructure
authorDanilo Krummrich <dakr@kernel.org>
Tue, 24 Mar 2026 00:59:10 +0000 (01:59 +0100)
committerDanilo Krummrich <dakr@kernel.org>
Fri, 3 Apr 2026 22:45:14 +0000 (00:45 +0200)
commit8a700b1fc94df4d847a04f14ebc7f8532592b367
tree4d42fbe50e554b85a912695dece36b21c3073d7d
parent10a4206a24013be4d558d476010cbf2eb4c9fa64
platform/wmi: use generic driver_override infrastructure

When a driver is probed through __driver_attach(), the bus' match()
callback is called without the device lock held, thus accessing the
driver_override field without a lock, which can cause a UAF.

Fix this by using the driver-core driver_override infrastructure taking
care of proper locking internally.

Note that calling match() from __driver_attach() without the device lock
held is intentional. [1]

Link: https://lore.kernel.org/driver-core/DGRGTIRHA62X.3RY09D9SOK77P@kernel.org/
Reported-by: Gui-Dong Han <hanguidong02@gmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220789
Fixes: 12046f8c77e0 ("platform/x86: wmi: Add driver_override support")
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://patch.msgid.link/20260324005919.2408620-7-dakr@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/platform/wmi/core.c
include/linux/wmi.h