]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging:iio:ad2s90: Make probe handle spi_setup failure
authorMatheus Tavares <matheus.bernardino@usp.br>
Sat, 3 Nov 2018 22:49:44 +0000 (19:49 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Feb 2019 18:44:52 +0000 (19:44 +0100)
commit8a9cf43e72a5b8b3721657a8601aaefaac14287a
tree7721875b4998edba0fb38f86896c2a79040b24a0
parentdd57ad3e75034499bd862cbe76fe444397ac0a36
staging:iio:ad2s90: Make probe handle spi_setup failure

[ Upstream commit b3a3eafeef769c6982e15f83631dcbf8d1794efb ]

Previously, ad2s90_probe ignored the return code from spi_setup, not
handling its possible failure. This patch makes ad2s90_probe check if
the code is an error code and, if so, do the following:

- Call dev_err with an appropriate error message.
- Return the spi_setup's error code.

Note: The 'return ret' statement could be out of the 'if' block, but
this whole block will be moved up in the function in the patch:
'staging:iio:ad2s90: Move device registration to the end of probe'.

Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/iio/resolver/ad2s90.c