]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtnl: add helper to check if rtnl group has listeners
authorJamal Hadi Salim <jhs@mojatatu.com>
Fri, 8 Dec 2023 19:28:41 +0000 (16:28 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:43:25 +0000 (10:43 +0200)
commit8ab0c35a9569296249b5fd04b90759c18de41ee0
tree2f970222de3bdbaeee61bf5de7d9c69868d72491
parentf3ce4d3f874ab7919edca364c147ac735f9f1d04
rtnl: add helper to check if rtnl group has listeners

[ Upstream commit c5e2a973448d958feb7881e4d875eac59fdeff3d ]

As of today, rtnl code creates a new skb and unconditionally fills and
broadcasts it to the relevant group. For most operations this is okay
and doesn't waste resources in general.

When operations are done without the rtnl_lock, as in tc-flower, such
skb allocation, message fill and no-op broadcasting can happen in all
cores of the system, which contributes to system pressure and wastes
precious cpu cycles when no one will receive the built message.

Introduce this helper so rtnetlink operations can simply check if someone
is listening and then proceed if necessary.

Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Link: https://lore.kernel.org/r/20231208192847.714940-2-pctammela@mojatatu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Stable-dep-of: 369609fc6272 ("tc: Ensure we have enough buffer space when sending filter netlink notifications")
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/rtnetlink.h