]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: usbip: Fix BUG: KASAN: slab-out-of-bounds in vhci_hub_control()
authorShuah Khan (Samsung OSG) <shuah@kernel.org>
Fri, 5 Oct 2018 22:17:44 +0000 (16:17 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 10 Nov 2018 15:49:46 +0000 (07:49 -0800)
commit8ae5849083f4bf5af72932a9982591ba374c248a
tree809c764bafea0df4d57cfee199e3afbe221301d7
parentb69c7f45b2d344dcf38f6247ec872718a61a2166
usb: usbip: Fix BUG: KASAN: slab-out-of-bounds in vhci_hub_control()

commit 81f7567c51ad97668d1c3a48e8ecc482e64d4161 upstream.

vhci_hub_control() accesses port_status array with out of bounds port
value. Fix it to reference port_status[] only with a valid rhport value
when invalid_rhport flag is true.

The invalid_rhport flag is set early on after detecting in port value
is within the bounds or not.

The following is used reproduce the problem and verify the fix:
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14ed8ab6400000

Reported-by: syzbot+bccc1fe10b70fadc78d0@syzkaller.appspotmail.com
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/vhci_hcd.c