]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tcp: Fix integer-overflows in TCP veno
authorChristoph Paasch <christoph.paasch@uclouvain.be>
Tue, 29 Jul 2014 10:07:27 +0000 (12:07 +0200)
committerWilly Tarreau <w@1wt.eu>
Sun, 23 Nov 2014 09:55:41 +0000 (10:55 +0100)
commit8b2de953aafa1fc799c0ca1e48ca615f884d9bc0
tree23a6b6f600158190db4ae35325c60a9d810f7c76
parentcf903573620912e1562dc4efe793a3c2e28b188a
tcp: Fix integer-overflows in TCP veno

[ Upstream commit 45a07695bc64b3ab5d6d2215f9677e5b8c05a7d0 ]

In veno we do a multiplication of the cwnd and the rtt. This
may overflow and thus their result is stored in a u64. However, we first
need to cast the cwnd so that actually 64-bit arithmetic is done.

A first attempt at fixing 76f1017757aa0 ([TCP]: TCP Veno congestion
control) was made by 159131149c2 (tcp: Overflow bug in Vegas), but it
failed to add the required cast in tcp_veno_cong_avoid().

Fixes: 76f1017757aa0 ([TCP]: TCP Veno congestion control)
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/ipv4/tcp_veno.c