]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
selftests/bpf: test_progs avoid minus shell exit codes
authorJesper Dangaard Brouer <brouer@redhat.com>
Tue, 7 Jul 2020 07:12:25 +0000 (09:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 11:07:33 +0000 (13:07 +0200)
commit8b6aebd9aff8ef36430fad4f98ec1d64ea12b63f
tree805bc659d05b739859ea6c8ac28eef1eaac64cb4
parent44e8963f50ebf6472dad487f6ae352a0159fef0d
selftests/bpf: test_progs avoid minus shell exit codes

[ Upstream commit b8c50df0cb3eb9008f8372e4ff0317eee993b8d1 ]

There are a number of places in test_progs that use minus-1 as the argument
to exit(). This is confusing as a process exit status is masked to be a
number between 0 and 255 as defined in man exit(3). Thus, users will see
status 255 instead of minus-1.

This patch use positive exit code 3 instead of minus-1. These cases are put
in the same group of infrastructure setup errors.

Fixes: fd27b1835e70 ("selftests/bpf: Reset process and thread affinity after each test/sub-test")
Fixes: 811d7e375d08 ("bpf: selftests: Restore netns after each test")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/159410594499.1093222.11080787853132708654.stgit@firesoul
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/bpf/test_progs.c