]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amd/ras: Reduce stack usage in ras_umc_handle_bad_pages()
authorSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Fri, 5 Dec 2025 12:07:57 +0000 (17:37 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 8 Dec 2025 19:25:37 +0000 (14:25 -0500)
commit8b971ce0cbc71a10f1d19d2bb6f3dc5c6f07d9d9
tree38b7532617a9aa42a6d0fcfbfc4d227b6ed0c423
parente3b8d8cc8c60db6c2be1251664da68b3e021a672
drm/amd/ras: Reduce stack usage in ras_umc_handle_bad_pages()

ras_umc_handle_bad_pages() function used a large local array:
  struct eeprom_umc_record records[MAX_ECC_NUM_PER_RETIREMENT];

Move this array off the stack by allocating it with kcalloc()
and freeing it before return.

This reduces the stack frame size of ras_umc_handle_bad_pages()
and avoids the frame size warning.

Fixes the below:
drivers/gpu/drm/amd/amdgpu/../ras/rascore/ras_umc.c:498:5: warning: stack frame size (1208) exceeds limit (1024) in 'ras_umc_handle_bad_pages' [-Wframe-larger-than]

v2: Removed the duplicate ras_umc_get_new_records() invocation. (Lijo)

Cc: Tao Zhou <tao.zhou1@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/ras/rascore/ras_umc.c