]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
radeon: use memcpy_to/fromio for UVD fw upload
authorChen Li <chenli@uniontech.com>
Fri, 4 Jun 2021 08:43:02 +0000 (16:43 +0800)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:48:22 +0000 (08:48 -0400)
commit8bc97e82cae1c2eb21150aabfece872d351d0642
tree2275966516f86465a02169c3bbf4d3b63df78848
parent349f4b6cd08e7b57cf235384034e5a6046bdc709
radeon: use memcpy_to/fromio for UVD fw upload

[ Upstream commit ab8363d3875a83f4901eb1cc00ce8afd24de6c85 ]

I met a gpu addr bug recently and the kernel log
tells me the pc is memcpy/memset and link register is
radeon_uvd_resume.

As we know, in some architectures, optimized memcpy/memset
may not work well on device memory. Trival memcpy_toio/memset_io
can fix this problem.

BTW, amdgpu has already done it in:
commit ba0b2275a678 ("drm/amdgpu: use memcpy_to/fromio for UVD fw upload"),
that's why it has no this issue on the same gpu and platform.

Signed-off-by: Chen Li <chenli@uniontech.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/radeon/radeon_uvd.c