]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
x86/mm: Check return value from memblock_phys_alloc_range()
authorPhilip Redkin <me@rarity.fan>
Fri, 15 Nov 2024 17:36:59 +0000 (20:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:40:04 +0000 (14:40 +0200)
commit8c18c904d301ffeb33b071eadc55cd6131e1e9be
tree0ad5f274103977d66ce7007a37a6c39aaa8e6add
parentfa73abd3599ee5d893aabda5c19c8e7b1b9ec2c8
x86/mm: Check return value from memblock_phys_alloc_range()

[ Upstream commit 631ca8909fd5c62b9fda9edda93924311a78a9c4 ]

At least with CONFIG_PHYSICAL_START=0x100000, if there is < 4 MiB of
contiguous free memory available at this point, the kernel will crash
and burn because memblock_phys_alloc_range() returns 0 on failure,
which leads memblock_phys_free() to throw the first 4 MiB of physical
memory to the wolves.

At a minimum it should fail gracefully with a meaningful diagnostic,
but in fact everything seems to work fine without the weird reserve
allocation.

Signed-off-by: Philip Redkin <me@rarity.fan>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Rik van Riel <riel@surriel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Link: https://lore.kernel.org/r/94b3e98f-96a7-3560-1f76-349eb95ccf7f@rarity.fan
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/mm/init.c