]> git.ipfire.org Git - thirdparty/vala.git/commit
glib-2.0: Fix potential null pointer dereference in string.joinv()
authorPhilip Withnall <withnall@endlessm.com>
Tue, 5 Dec 2017 11:59:32 +0000 (11:59 +0000)
committerRico Tzschichholz <ricotz@ubuntu.com>
Sat, 9 Dec 2017 13:34:50 +0000 (14:34 +0100)
commit8c1c7641efce8321377a8b4c7c7cf3c21175b545
treef126f39713d7c03f08f805dfd6fd83a9c8898885
parent9d88b804359c20c5633d990135607ddb728a95d9
glib-2.0: Fix potential null pointer dereference in string.joinv()

The logic in the ‘is the array null or empty’ check was disjunctive
rather than conjunctive. If (str_array == null), the condition would
have short-circuited and tried to evaluate str_array.length, which would
have crashed.

Coverity CID: #1462389 (spotted when scanning Tracker)

https://bugzilla.gnome.org/show_bug.cgi?id=791257
vapi/glib-2.0.vapi