]> git.ipfire.org Git - thirdparty/asterisk.git/commit
res_rtp_asterisk: Fix regression issues with DTLS client check
authorGeorge Joseph <gjoseph@sangoma.com>
Fri, 15 Dec 2023 16:37:54 +0000 (09:37 -0700)
committerasterisk-org-access-app[bot] <120671045+asterisk-org-access-app[bot]@users.noreply.github.com>
Wed, 20 Dec 2023 14:02:33 +0000 (14:02 +0000)
commit8c3ececb12d82ee5d63adad6b9f9e79ad239e803
tree2bb82b4905000359b3b5b74fa2a3fa6c4bf552e5
parenta1ca0268254374b515fa5992f01340f7717113fa
res_rtp_asterisk: Fix regression issues with DTLS client check

* Since ICE candidates are used for the check and pjproject is
  required to use ICE, res_rtp_asterisk was failing to compile
  when pjproject wasn't available.  The check is now wrapped
  with an #ifdef HAVE_PJPROJECT.

* The rtp->ice_active_remote_candidates container was being
  used to check the address on incoming packets but that
  container doesn't contain peer reflexive candidates discovered
  during negotiation. This was causing the check to fail
  where it shouldn't.  We now check against pjproject's
  real_ice->rcand array which will contain those candidates.

* Also fixed a bug in ast_sockaddr_from_pj_sockaddr() where
  we weren't zeroing out sin->sin_zero before returning.  This
  was causing ast_sockaddr_cmp() to always return false when
  one of the inputs was converted from a pj_sockaddr, even
  if both inputs had the same address and port.

Resolves: #500
Resolves: #503
Resolves: #505
include/asterisk/res_pjproject.h
res/res_pjproject.c
res/res_rtp_asterisk.c