]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: intel: atom: Fix breakage for PCM buffer address setup
authorTakashi Iwai <tiwai@suse.de>
Thu, 19 Aug 2021 15:29:45 +0000 (17:29 +0200)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:35:18 +0000 (08:35 -0400)
commit8c5beac92d0e8f477226d2d7869764931458e71d
treedea1252cf2483f7717fa405da82dd1d565b0f0bd
parent8f4eb032a019cc6f6bdda5f78e1c50cebfb86c37
ASoC: intel: atom: Fix breakage for PCM buffer address setup

[ Upstream commit 65ca89c2b12cca0d473f3dd54267568ad3af55cc ]

The commit 2e6b836312a4 ("ASoC: intel: atom: Fix reference to PCM
buffer address") changed the reference of PCM buffer address to
substream->runtime->dma_addr as the buffer address may change
dynamically.  However, I forgot that the dma_addr field is still not
set up for the CONTINUOUS buffer type (that this driver uses) yet in
5.14 and earlier kernels, and it resulted in garbage I/O.  The problem
will be fixed in 5.15, but we need to address it quickly for now.

The fix is to deduce the address again from the DMA pointer with
virt_to_phys(), but from the right one, substream->runtime->dma_area.

Fixes: 2e6b836312a4 ("ASoC: intel: atom: Fix reference to PCM buffer address")
Reported-and-tested-by: Hans de Goede <hdegoede@redhat.com>
Cc: <stable@vger.kernel.org>
Acked-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/2048c6aa-2187-46bd-6772-36a4fb3c5aeb@redhat.com
Link: https://lore.kernel.org/r/20210819152945.8510-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/intel/atom/sst-mfld-platform-pcm.c