]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
video: fbdev: pvr2fb: initialize variables
authorTom Rix <trix@redhat.com>
Mon, 20 Jul 2020 19:18:45 +0000 (12:18 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Nov 2020 10:08:39 +0000 (11:08 +0100)
commit8c755f49ac7cdae0d704c99e8299018aaa761fbe
tree71fcead800f03d86017466ca99c50272701c9976
parentbda64b43564ac3eca39202db4f1462487ca4a6bf
video: fbdev: pvr2fb: initialize variables

[ Upstream commit 8e1ba47c60bcd325fdd097cd76054639155e5d2e ]

clang static analysis reports this repesentative error

pvr2fb.c:1049:2: warning: 1st function call argument
  is an uninitialized value [core.CallAndMessage]
        if (*cable_arg)
        ^~~~~~~~~~~~~~~

Problem is that cable_arg depends on the input loop to
set the cable_arg[0].  If it does not, then some random
value from the stack is used.

A similar problem exists for output_arg.

So initialize cable_arg and output_arg.

Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/fbdev/pvr2fb.c