]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
configfs: Do not override creating attribute file failure in populate_attrs()
authorZijun Hu <quic_zijuhu@quicinc.com>
Wed, 7 May 2025 11:50:26 +0000 (19:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:05:22 +0000 (11:05 +0100)
commit8cb51a55b26eadc671748adbac12ebb2375ec9c1
treeb6d9f5a5c2cf4bc47b4d17b5630c3b2a375811c9
parent4ad892bdacb61323423bf09d22d7f5ccf4df3830
configfs: Do not override creating attribute file failure in populate_attrs()

commit f830edbae247b89228c3e09294151b21e0dc849c upstream.

populate_attrs() may override failure for creating attribute files
by success for creating subsequent bin attribute files, and have
wrong return value.

Fix by creating bin attribute files under successfully creating
attribute files.

Fixes: 03607ace807b ("configfs: implement binary attributes")
Cc: stable@vger.kernel.org
Reviewed-by: Joel Becker <jlbec@evilplan.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20250507-fix_configfs-v3-2-fe2d96de8dc4@quicinc.com
Signed-off-by: Andreas Hindborg <a.hindborg@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/configfs/dir.c