]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fprobe: Fix module reference count leak on error in register_fprobe()
authorMasami Hiramatsu (Google) <mhiramat@kernel.org>
Tue, 28 Jul 2026 23:27:33 +0000 (08:27 +0900)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Wed, 29 Jul 2026 13:50:02 +0000 (22:50 +0900)
commit8cf2f40ceb85047ad8a84dffae3bebc9fed18216
tree97573d0466dbdd10453b6843798ee5d26922f4a8
parentaca0cd1bf16574327ef64f3178e5f5e37a61ef0b
fprobe: Fix module reference count leak on error in register_fprobe()

In register_fprobe(), get_ips_from_filter() resolves target function
addresses and increments module reference counts via try_module_get() for
symbols in kernel modules. If get_ips_from_filter() fails on the second
pass and returns an error, register_fprobe() returned directly without
releasing module references acquired up to that point.

Fix this by ensuring the cleanup loop executing module_put() runs even when
get_ips_from_filter() returns a negative error.

Link: https://lore.kernel.org/all/178528125360.101985.4144133640239273153.stgit@devnote2/
Fixes: d24fa977eec5 ("tracing: fprobe: Fix to lock module while registering fprobe")
Assisted-by: Antigravity:gemini-3.6-flash
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
kernel/trace/fprobe.c