]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: stmmac: Update default_an_inband before passing value to phylink_config
authorKhaiWenTan <khai.wen.tan@linux.intel.com>
Thu, 16 Apr 2026 10:26:09 +0000 (18:26 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 18 Apr 2026 19:10:16 +0000 (12:10 -0700)
commit8cff9dbe89d8bd44d9a5e631c9394dd3901ffd79
tree286a8ddb1524675a3b36989c45ba94f90788c01c
parentf996edd7615e686ada141b7f3395025729ff8ccb
net: stmmac: Update default_an_inband before passing value to phylink_config

get_interfaces() will update both the plat->phy_interfaces and
mdio_bus_data->default_an_inband based on reading a SERDES register. As
get_interfaces() will be called after default_an_inband had already been
read, dwmac-intel regressed as a result with incorrect default_an_inband
value in phylink_config.

Therefore, we moved the priv->plat->get_interfaces() to be executed first
before assigning priv->plat->default_an_inband to config->default_an_inband
to ensure default_an_inband is in correct value.

Fixes: d3836052fe09 ("net: stmmac: intel: convert speed_mode_2500() to get_interfaces()")
Signed-off-by: KhaiWenTan <khai.wen.tan@linux.intel.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/20260416102609.7953-1-khai.wen.tan@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c