]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
EDAC: i7core, sb_edac: Don't return NOTIFY_BAD from mce_decoder callback
authorTony Luck <tony.luck@intel.com>
Fri, 29 Apr 2016 13:42:25 +0000 (15:42 +0200)
committerWilly Tarreau <w@1wt.eu>
Tue, 7 Jun 2016 08:42:51 +0000 (10:42 +0200)
commit8d418eb36789e23e9b5ed41648fb93c88a7c30fa
tree8bc5b5cb55eacc1228b55c48845cba80e1d181c1
parentfaf35c269ae62e88b23e271682a18c6f0d5f83a0
EDAC: i7core, sb_edac: Don't return NOTIFY_BAD from mce_decoder callback

commit c4fc1956fa31003bfbe4f597e359d751568e2954 upstream.

Both of these drivers can return NOTIFY_BAD, but this terminates
processing other callbacks that were registered later on the chain.
Since the driver did nothing to log the error it seems wrong to prevent
other interested parties from seeing it. E.g. neither of them had even
bothered to check the type of the error to see if it was a memory error
before the return NOTIFY_BAD.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Acked-by: Aristeu Rozanski <aris@redhat.com>
Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/72937355dd92318d2630979666063f8a2853495b.1461864507.git.tony.luck@intel.com
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/edac/i7core_edac.c
drivers/edac/sb_edac.c