]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfsd: Limit end of page list when decoding NFSv4 WRITE
authorChuck Lever <chuck.lever@oracle.com>
Fri, 18 Aug 2017 15:12:19 +0000 (11:12 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2017 08:26:39 +0000 (10:26 +0200)
commit8d4f126c0791c4fa38a294cc4c2fa6ca0b21b562
treeb0986d90a0c6e76e148f1b45416046d04456b179
parentea5745a5117fd1e1cbd4497ea51367b10e3881f0
nfsd: Limit end of page list when decoding NFSv4 WRITE

commit fc788f64f1f3eb31e87d4f53bcf1ab76590d5838 upstream.

When processing an NFSv4 WRITE operation, argp->end should never
point past the end of the data in the final page of the page list.
Otherwise, nfsd4_decode_compound can walk into uninitialized memory.

More critical, nfsd4_decode_write is failing to increment argp->pagelen
when it increments argp->pagelist.  This can cause later xdr decoders
to assume more data is available than really is, which can cause server
crashes on malformed requests.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfsd/nfs4xdr.c