]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/arm: Don't specify ID_PFR1 accessfn twice
authorPeter Maydell <peter.maydell@linaro.org>
Wed, 31 Dec 2025 17:08:55 +0000 (17:08 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 15 Jan 2026 15:27:34 +0000 (15:27 +0000)
commit8da52b8401afa34ea8caa58e1bfb321ae142899b
tree189de42c66a12026b4b699f9ce3f2f9f41969621
parent7cf096d609e67fd06abf6a59e592cb6de427825c
target/arm: Don't specify ID_PFR1 accessfn twice

In the definition of ID_PFR1 we have an ifdef block; we specify the
accessfn once in the common part of the ifdef and once in the
not-user-only part, which is redundant but harmless.

The accessfn will always return success in user-only mode (because
we won't trap to EL2), so specify it only in the not-user-only
half of the ifdef, as was probably the intention.

This is only cc'd to stable to avoid a textual conflict with
the following patch, which is a bug fix.

Cc: qemu-stable@nongnu.org
Fixes: 0f150c8499e970bd ("target/arm: Constify ID_PFR1 on user emulation")
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20251231170858.254594-2-peter.maydell@linaro.org
target/arm/helper.c