]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tcp: fix wrong checksum calculation on MTU probing
authorDouglas Caetano dos Santos <douglascs@taghos.com.br>
Thu, 22 Sep 2016 18:52:04 +0000 (15:52 -0300)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 16 Mar 2017 02:27:19 +0000 (02:27 +0000)
commit8db120b977d99663bcfc5d8bc2bc442558711e99
tree461dfebeef8d4c7948cdba60526390ea46480452
parent583024310463390696eae615acba9ab39cb8c7b8
tcp: fix wrong checksum calculation on MTU probing

[ Upstream commit 2fe664f1fcf7c4da6891f95708a7a56d3c024354 ]

With TCP MTU probing enabled and offload TX checksumming disabled,
tcp_mtu_probe() calculated the wrong checksum when a fragment being copied
into the probe's SKB had an odd length. This was caused by the direct use
of skb_copy_and_csum_bits() to calculate the checksum, as it pads the
fragment being copied, if needed. When this fragment was not the last, a
subsequent call used the previous checksum without considering this
padding.

The effect was a stale connection in one way, as even retransmissions
wouldn't solve the problem, because the checksum was never recalculated for
the full SKB length.

Signed-off-by: Douglas Caetano dos Santos <douglascs@taghos.com.br>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv4/tcp_output.c