]> git.ipfire.org Git - thirdparty/linux.git/commit
ksmbd: remove redundant DACL check in smb_check_perm_dacl
authorAlexey Velichayshiy <a.velichayshiy@ispras.ru>
Wed, 10 Dec 2025 13:51:33 +0000 (16:51 +0300)
committerSteve French <stfrench@microsoft.com>
Mon, 15 Dec 2025 00:35:56 +0000 (18:35 -0600)
commit8dd2e58b62731a96e276ee0545fb910ffb2057d9
treeb294cf76b3e1844731c847b6a96247817d7b87e6
parent0446356e9f29d81757dc64ae7c61743e28d91ac0
ksmbd: remove redundant DACL check in smb_check_perm_dacl

A zero value of pdacl->num_aces is already handled at the start of
smb_check_perm_dacl() so the second check is useless.

Drop the unreachable code block, no functional impact intended.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Alexey Velichayshiy <a.velichayshiy@ispras.ru>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smbacl.c