]> git.ipfire.org Git - thirdparty/git.git/commit
sparse-checkout: reject arguments in cone-mode that look like patterns
authorElijah Newren <newren@gmail.com>
Sat, 19 Feb 2022 16:44:45 +0000 (16:44 +0000)
committerJunio C Hamano <gitster@pobox.com>
Sun, 20 Feb 2022 08:01:15 +0000 (00:01 -0800)
commit8dd7c4739bded62175bea1f7518d993b39b51f90
treedf900e4300dc8d018d3a2ffb6611551111c96e9a
parent4ce504360bc3b240e570281fabe00a85027532c3
sparse-checkout: reject arguments in cone-mode that look like patterns

In sparse-checkout add/set under cone mode, the arguments passed are
supposed to be directories rather than gitignore-style patterns.
However, given the amount of effort spent in the manual discussing
patterns, it is easy for users to assume they need to pass patterns such
as
   /foo/*
or
   !/bar/*/
or perhaps they really do ignore the directory rule and specify a
random gitignore-style pattern like
   *.c

To help catch such mistakes, throw an error if any of the positional
arguments:
  * starts with any of '/!'
  * contains any of '*?[]'

Inform users they can pass --skip-checks if they have a directory that
really does have such special characters in its name.  (We exclude '\'
because of sparse-checkout's special handling of backslashes; see
the MINGW test in t1091.46.)

Reviewed-by: Derrick Stolee <derrickstolee@github.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/sparse-checkout.c
t/t1091-sparse-checkout-builtin.sh