]> git.ipfire.org Git - thirdparty/krb5.git/commit
Fix various integer issues
authorTom Yu <tlyu@mit.edu>
Fri, 11 Jan 2013 20:53:23 +0000 (15:53 -0500)
committerTom Yu <tlyu@mit.edu>
Fri, 11 Jan 2013 20:54:58 +0000 (15:54 -0500)
commit8e31374995eaa4515323e56d1579ee7ad0ebc4ca
tree057cc1522c39ebcd0f9c859923af78fd25af2215
parent9bbf3649867f444674716941b787f6699885c803
Fix various integer issues

In kdc_util.c and spnego_mech.c, error returns from ASN.1 length
functions could be ignored because they were assigned to unsigned
values.  In spnego_mech.c, two buffer size checks could be rewritten
to reduce the likelihood of pointer overflow.  In dump.c and
kdc_preauth.c, calloc() could be used to simplify the code and avoid
multiplication overflow.  In pkinit_clnt.c, the wrong value was
checked for a null result from malloc(), and the code could be
simplified.

Reported by Nickolai Zeldovich <nickolai@csail.mit.edu>.

(cherry picked from commit d3c5450ddf0b20855e86dab41735d56c6860156b)

[tlyu@mit.edu: omitted pkinit and kdb5_util fixes because they're not
conservative]

ticket: 7545 (new)
version_fixed: 1.10.4
status: resolved
src/kdc/kdc_preauth.c
src/kdc/kdc_util.c
src/lib/gssapi/spnego/spnego_mech.c