]> git.ipfire.org Git - thirdparty/git.git/commit
t/helper: fix segfault in "oid-array" command without repository
authorPatrick Steinhardt <ps@pks.im>
Fri, 14 Jun 2024 06:51:05 +0000 (08:51 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 14 Jun 2024 17:26:34 +0000 (10:26 -0700)
commit8e9a1d0dc2d543c05cb0c11a598fb7675d5deea8
tree74164c1fc022fa458cfee4a384fea9f83df10b3f
parentfa9e009aa74a2393067eb417d9eab3490d295fc8
t/helper: fix segfault in "oid-array" command without repository

The "oid-array" test helper can supposedly work without a Git
repository, but will in fact crash because `the_repository->hash_algo`
is not initialized. This is because `oid_pos()`, which is used by
`oid_array_lookup()`, depends on `the_hash_algo->rawsz`.

Ideally, we'd adapt `oid_pos()` to not depend on `the_hash_algo`
anymore. That is a bigger untertaking though, so instead we fall back to
SHA1 when there is no repository.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/helper/test-oid-array.c
t/t0064-oid-array.sh