]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: api - Fix race condition in larval lookup
authorNikola Pajkovsky <npajkovs@redhat.com>
Fri, 11 Oct 2013 06:48:34 +0000 (08:48 +0200)
committerWilly Tarreau <w@1wt.eu>
Mon, 19 May 2014 05:53:30 +0000 (07:53 +0200)
commit8ec40cab58d3b334077ff0f7bbc0f667c43f1583
tree6a2a11986af24ee254fbc5a00d1186c8cdc5dc33
parent70630fa3b7148ee07828587fedbf0ad3f895c8e8
crypto: api - Fix race condition in larval lookup

https://bugzilla.redhat.com/1016108

64z is missing rhel6 commit 3af031a395c0 ("[crypto] algboss: Hold ref
count on larval") which is causing cosmetic fuzz, because crypto_alg_get
was move from crypto/api.c to crypto/internal.h.

From: Herbert Xu <herbert@gondor.apana.org.au>

[ upstream commit 77dbd7a95e4a4f15264c333a9e9ab97ee27dc2aa ]

crypto_larval_lookup should only return a larval if it created one.
Any larval created by another entity must be processed through
crypto_larval_wait before being returned.

Otherwise this will lead to a larval being killed twice, which
will most likely lead to a crash.

Cc: stable@vger.kernel.org
Reported-by: Kees Cook <keescook@chromium.org>
Tested-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Nikola Pajkovsky <npajkovs@redhat.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
crypto/api.c