]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
topology: Fix compilation warning when not in SMP
authorVincent Stehlé <vincent.stehle@laposte.net>
Fri, 4 Apr 2014 06:43:18 +0000 (08:43 +0200)
committerJiri Slaby <jslaby@suse.cz>
Thu, 9 Apr 2015 12:13:24 +0000 (14:13 +0200)
commit8f2f5f1e02f8f280b70e7e50d3f40c1eb279c5d4
treec424c12f467bc38f1d137b7d5014f49b2b2bf6e6
parent51f4c06ed494ed6e01894a5d04ba3ce5cb9cd3dd
topology: Fix compilation warning when not in SMP

commit 53974e06603977f348ed978d75c426b0532daa67 upstream.

The topology_##name() macro does not use its argument when CONFIG_SMP is not
set, as it ultimately calls the cpu_data() macro.

So we avoid maintaining a possibly unused `cpu' variable, to avoid the
following compilation warning:

  drivers/base/topology.c: In function ‘show_physical_package_id’:
  drivers/base/topology.c:103:118: warning: unused variable ‘cpu’ [-Wunused-variable]
   define_id_show_func(physical_package_id);

  drivers/base/topology.c: In function ‘show_core_id’:
  drivers/base/topology.c:106:106: warning: unused variable ‘cpu’ [-Wunused-variable]
   define_id_show_func(core_id);

This can be seen with e.g. x86 defconfig and CONFIG_SMP not set.

Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/base/topology.c